417688 - Add context menu to copy URL for attached links in events/tasks

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Sven Giermann]

In Event/Task editing dialog and in Task preview (Lightning only), attached links are displayed as link and always browse to this link on click.

A context menu should be added to be able to only copy the URL to clipboard or browse to this URL.

This is a spin-off from bug 414537 comment #7.

Comment 1

[Merike Sell (:merike)]

Attachment: [after beta] adding context menu options

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 545016 [details] [diff] [review]
[after beta] adding context menu options

>+    var clipboard = Components.classes["@mozilla.org/widget/clipboardhelper;1"]
>+        .getService(Components.interfaces.nsIClipboardHelper);
Isn't there a Services.jsm helper for this maybe?

Also, let instead of var.

>+<!ENTITY event.attachments.popup.copy.label               "Copy Link Location" >
>+<!ENTITY event.attachments.popup.copy.accesskey           "C" >
If there is a toolkit string for this, maybe we can use that instead?

> <!ENTITY event.attachments.popup.attachPage.label         "Attach Webpageâ¦" >
Be careful with UTF-8 in this file.


>+<!ENTITY calendar.tasks.view.copylink.label       "Copy Link Location">
>+<!ENTITY calendar.tasks.view.copylink.accesskey   "C">
If there is no toolkit string, I think it should be sufficient to use one string for both menus.

r=philipp

Comment 3

[Merike Sell (:merike)]

Attachment: adding context menu options v2

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> >+    var clipboard = Components.classes["@mozilla.org/widget/clipboardhelper;1"]
> >+        .getService(Components.interfaces.nsIClipboardHelper);
> Isn't there a Services.jsm helper for this maybe?
Doesn't seem to be: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/Services.jsm

> >+<!ENTITY event.attachments.popup.copy.label               "Copy Link Location" >
> >+<!ENTITY event.attachments.popup.copy.accesskey           "C" >
> If there is a toolkit string for this, maybe we can use that instead?
There is one in /browser and one in /mobile but not in toolkit.

> > <!ENTITY event.attachments.popup.attachPage.label         "Attach Webpageâ¦" >
> Be careful with UTF-8 in this file.
Um, it seems fine in https://bug417688.bugzilla.mozilla.org/attachment.cgi?id=545016? Anyhow it's not in the patch any longer.

> >+<!ENTITY calendar.tasks.view.copylink.label       "Copy Link Location">
> >+<!ENTITY calendar.tasks.view.copylink.accesskey   "C">
> If there is no toolkit string, I think it should be sufficient to use one
> string for both menus.
Removed the other one.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/dfbe3fe97df9>

-> FIXED